Skip to content
This repository has been archived by the owner on May 18, 2022. It is now read-only.

profile editor too big #313

Open
arj03 opened this issue Jul 6, 2021 · 4 comments
Open

profile editor too big #313

arj03 opened this issue Jul 6, 2021 · 4 comments
Labels
bug Something isn't working

Comments

@arj03
Copy link
Owner

arj03 commented Jul 6, 2021

image

manage to capture this one now @KyleMaas. It happened when I started a new private chrome session, did manual and just navigated to the new profile.

@KyleMaas
Copy link
Collaborator

KyleMaas commented Jul 6, 2021

Ah. Okay...that's going to be an interesting one to try to track down.

@KyleMaas KyleMaas self-assigned this Jul 6, 2021
@KyleMaas KyleMaas added the bug Something isn't working label Jul 6, 2021
@KyleMaas
Copy link
Collaborator

KyleMaas commented Jul 6, 2021

This one may or may not be worth fixing right now - looks like they're having other problems with things exceeding the bounds of the editor. See:

nhn/tui.editor#1633

nhn/tui.editor#1627

@KyleMaas
Copy link
Collaborator

KyleMaas commented Jul 6, 2021

As far as I can tell, we would need to call classifyToolbarItems somehow:

https://github.com/nhn/tui.editor/blob/3983510e871bf4cfdd98131a45e447d8cad1fd86/apps/editor/src/ui/components/toolbar/toolbar.ts#L192

There are several things that call that, but I think considering it looks like they're going to have to do some work on overflow anyway that it's probably not worth adding a hacky solution that'll likely break in a newer version.

@KyleMaas KyleMaas removed their assignment Jul 6, 2021
@arj03
Copy link
Owner Author

arj03 commented Jul 7, 2021

Agree, lets wait and see.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants