Skip to content
This repository has been archived by the owner on May 18, 2022. It is now read-only.

Dedupe more libraries #240

Open
KyleMaas opened this issue Feb 16, 2021 · 10 comments
Open

Dedupe more libraries #240

KyleMaas opened this issue Feb 16, 2021 · 10 comments
Labels
enhancement New feature or request waiting for upstream Waiting for upstream changes to be made

Comments

@KyleMaas
Copy link
Collaborator

KyleMaas commented Feb 16, 2021

Other libraries we use multiple copies of:

  • chloride 2.2.14 pulled in by ssb-keys-mnemonic vs. 2.4.1 everywhere else
  • ssb-keys 7.2.2 almost everywhere except ssb-db2's 8.0.2 (ssb-room/ssb-client, ssb-room/ssb-config, ssb-validate, ssb-client, ssb-client/ssb-config)
  • ssb-config 3.3.3 from ssb-room and ssb-room/ssb-client vs 3.4.5 from ssb-client (direct dependency)
  • sodium-native 2.4.9 (which doesn't work for me) pulled in by ssb-keys-mnemonic/chloride vs. 3.2.1 used by ssb-browser-core/ssb-keys/chloride

I'd keep going, but I'm finding a lot more. Let me see what I can do to fix some of these. Some of them are minor version changes that shouldn't make a lick of difference.

Filed issues on this subject:

@arj03
Copy link
Owner

arj03 commented Feb 16, 2021

I think if you create PRs like for the ssb-keys-mnemonic we should be able to get them merged. The pull* modules might be a bigger problem as they are not actively maintained sadly. The flume stuff shoul not be used. Might be pulled in like in friends but shouldn't be used.

@KyleMaas
Copy link
Collaborator Author

flumecodec is pulled in by ssb-friends (via flumeview-reduce) and atomic-file, both dependencies of ssb-browser-core.

@arj03
Copy link
Owner

arj03 commented Feb 16, 2021

Right, this reminds me, we need to remove the atomic-file dependency in ssb-browser-core in favor of atomically-universal. Is that something you are up for?

@arj03
Copy link
Owner

arj03 commented Feb 16, 2021

@KyleMaas
Copy link
Collaborator Author

KyleMaas commented Feb 16, 2021

staltz/ssb-keys-mnemonic#3

@KyleMaas
Copy link
Collaborator Author

KyleMaas commented Feb 16, 2021

ssbc/ssb-friends#56

@KyleMaas
Copy link
Collaborator Author

KyleMaas commented Feb 16, 2021

@KyleMaas
Copy link
Collaborator Author

@KyleMaas
Copy link
Collaborator Author

KyleMaas commented Feb 16, 2021

See #244 for a patch for some of these.

@KyleMaas KyleMaas added enhancement New feature or request waiting for upstream Waiting for upstream changes to be made labels Feb 16, 2021
@KyleMaas
Copy link
Collaborator Author

I think I've done about everything I can to fix this locally. I'm going to leave this open to show progress on dependencies, but for now, I don't think there's much more we can do here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request waiting for upstream Waiting for upstream changes to be made
Projects
None yet
Development

No branches or pull requests

2 participants