Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve responsiveness/wrapping #3

Open
aricooperdavis opened this issue Oct 10, 2022 · 1 comment
Open

Improve responsiveness/wrapping #3

aricooperdavis opened this issue Oct 10, 2022 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@aricooperdavis
Copy link
Owner

aricooperdavis commented Oct 10, 2022

The custom banner is laid out like so:

<div class="custom-banner-container"> <! invisible container -->
   <div class="custom-banner-body"> <! banner background -->
      <div class="custom-banner-content"></div> <! banner content -->
      <div class="custom-banner-actions"> <! invisible container -->
         <a class="button custom-banner-button"></a> <! action button -->
         <a class="button custom-banner-dismiss"></a> <! dismiss button -->
      </div>
   <div>
</div>

When...

...then the banner content can cause the buttons to overflow off the end of the custom-banner-body which looks ugly:

image

I'm no expert at responsive CSS, so if anyone fancies looking into this in more detail I'd be very grateful!

@aricooperdavis aricooperdavis added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Oct 10, 2022
@yehudaclinton
Copy link

Also does not work well for mobile. I see one word per line

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants