Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Mode buttons missing in v10 #35

Open
1 task done
jagoe opened this issue Nov 18, 2022 · 3 comments · May be fixed by #36
Open
1 task done

[Bug]: Mode buttons missing in v10 #35

jagoe opened this issue Nov 18, 2022 · 3 comments · May be fixed by #36
Assignees
Labels
bug Something isn't working

Comments

@jagoe
Copy link

jagoe commented Nov 18, 2022

Expected Behavior

In Foundry v10, the mode buttons should appear in the combat tracker.

Current Behavior

The mode buttons do not appear.

Steps to Reproduce

  1. Use Foundry v10
  2. Open the combat tracker
  3. No mode buttons

Context

From what I can tell, the reason is that the module expects #combat > #combat-round to exist, but it does not.
I could produce the correct behavior by changing the query to .combat-tracker-header.

Version

1.4.3

Foundry VTT Version

10.290

Operating System

Windows, Linux (Mint)

Browser / App

Chrome

Game System

dnd5e (2.0.3)

Modules Disabled

  • I can confirm that disabling all of my other modules doesn't fix this issue.
@jagoe jagoe added the bug Something isn't working label Nov 18, 2022
@jagoe jagoe linked a pull request Nov 21, 2022 that will close this issue
@AuraofMana
Copy link

AuraofMana commented Dec 24, 2022

It's been more than a month. Why hasn't this been merged yet? @arcanistzed

@Haxxer
Copy link

Haxxer commented Dec 25, 2022

It's been more than a month. Why hasn't this been merged yet? @arcanistzed

  1. It's the end of the year, people are on holidays and/or are busy with non-foundry things.
  2. No one owes you anything, we module developers do this for fun, on our free time, FOR FREE. Your entitled attitude is what drives people away from making this vibrant community what it is, and leaves a sour taste in developers' mouths.
  3. There are a thousand different ways that you could have nicely asked if there's a timeline for a merge, instead of the rude sentence you offered.
  4. Hell, you're not even the contributor of the fix.

@AuraofMana
Copy link

Ahh, I sincerely apologize. I just realized I wrote it in a way that sounds rude. I meant to ask about the timeline. Definitely wasn't my intent, sorry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants