Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track connection staleness #48

Open
whereswaldon opened this issue Dec 8, 2018 · 1 comment
Open

Track connection staleness #48

whereswaldon opened this issue Dec 8, 2018 · 1 comment
Labels
enhancement New feature or request

Comments

@whereswaldon
Copy link
Member

There are circumstances right now in which your client will be disconnected from the server without being aware of it until it tries to actively communicate. It would be a much better user experience if we caught these proactively.

Essentially, I propose that:

  • We keep a timer of how long it has been since we received data from the server
  • Whenever a message of any kind comes from the server, we reset that timer
  • When the timer hits some threshold (30 seconds?), we send an innocuous message that should yield a response from the server (right now, I think this should be a query for the root message).
  • If the timer ever hits 60 seconds, we should close and reopen the connection to the server.

I also would like to keep the value within this timer visible to the user somewhere within the TUI.

@whereswaldon whereswaldon added the enhancement New feature or request label Dec 8, 2018
@whereswaldon
Copy link
Member Author

Everything except making the timer visible was implemented by #53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant