Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add a "notes" text field to a Knight's profile #80

Open
LadyVulcan opened this issue Jul 7, 2022 · 5 comments
Open

Please add a "notes" text field to a Knight's profile #80

LadyVulcan opened this issue Jul 7, 2022 · 5 comments
Assignees
Labels
Core Code Requirement fullfillment enhancement New feature or request

Comments

@LadyVulcan
Copy link

Is your feature request related to a problem? Please describe.
Occasionally Knights will change their Discord name or Reddit name. I would like to make historical records of any old usernames that I am updating, so that information isn't lost.

Describe the solution you'd like
Another text field called "Notes", in addition to the "About Me" and "Real life" test fields on a user. This text field would ideally be visible only to Commanders or higher. However, that privacy feature is not necessary for minimum viable product.

Describe alternatives you've considered
Currently I add old usernames to the "About Me" or "Real life" text fields. However, this is an awkward workaround, especially when the Knight put time into the original data population form and has personal text there already. See: Balsa.

Additional context
Nah

@LadyVulcan LadyVulcan added the Core Code Requirement fullfillment label Jul 7, 2022
@Gryph667 Gryph667 added the enhancement New feature or request label Jul 7, 2022
@Gryph667
Copy link
Contributor

Gryph667 commented Jul 7, 2022

This will require changes to both controllers and the database.

@Gryph667
Copy link
Contributor

Gryph667 commented Jul 7, 2022

Do we want a single field, or the ability to add multiple notes, with variable visibility? @LadyVulcan

@Palpiter
Copy link

Palpiter commented Jul 8, 2022

Potentially overkill solution for Squire: We could handle Accounts as objects independent of Users and link them with 0/1:N relations in the database.
That way we'd have the existing table of users, a new table of accounts and we'd be able to assign N accounts to a user with a drop-down list of "primary reddit / alt reddit / primary discord / alt discord / etc." and maybe a notes field per account to cover special cases or additional information (eg. "acc renamed 20XX").

@Gryph667
Copy link
Contributor

We could handle Accounts as objects independent of Users and link them with 0/1:N relations in the database.

This would be a way down the road map item. While we're using Reddit for authentication, I'm hesitant at adding that much complexity at this time.

@Gryph667
Copy link
Contributor

Schema Development: Adding field dbo.knight.onotes with attributes varchar(2000).

Minimum deliverable is plain text, with the eventual goal of adding html formatting possible, and saving the notes as a blob.

UX Requirements: Rather than displaying the Notes in the main profile show blade, concept I'm going with is a link that opens a pop up dialog box that displays and allows editing of the field.

Further down the road, we can add a new table with just note records done as many to one relationships so we can see who wrote which notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Code Requirement fullfillment enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants