Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifications to the Profile pages #69

Open
Gryph667 opened this issue Jun 4, 2022 · 1 comment
Open

Modifications to the Profile pages #69

Gryph667 opened this issue Jun 4, 2022 · 1 comment
Assignees
Labels
Core Code Requirement fullfillment

Comments

@Gryph667
Copy link
Contributor

Gryph667 commented Jun 4, 2022

Is your feature request related to a problem? Please describe.
We've added DiscordID to the knight table. Neither it nor inttrans (Interview Transcript) are available or editable in the application. [...]

Describe the solution you'd like
Both of these fields need to be added to the edit.profile.blade, show.profile.blade and new.profile.blade files.
Both of them should be visible and editable by anyone that can use new.profile.blade. For the show.profile.blade and edit.profile.blade files, they should match the same security visibility and edit access as the Knight Number field.

Describe alternatives you've considered
Potentially make both of these fields part of a new profile.blade file only accessible via the Admin pages.

Additional context
The DiscordID especially is critical as a user cannot change this value without changing their entire Discord account. Discord Name on the other hand can be manipulated by the user at will.

@Gryph667 Gryph667 added the Core Code Requirement fullfillment label Jun 4, 2022
@Gryph667
Copy link
Contributor Author

As per @LeoVerto this is going to require an examination of the code base to refresh working knowledge of application architecture. Once ready, @Gryph667 is projecting about 5 hours to adjust the files, test them on local environments, and prepare pull requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Code Requirement fullfillment
Projects
None yet
Development

No branches or pull requests

3 participants