Skip to content
This repository has been archived by the owner on Aug 6, 2024. It is now read-only.

feat: Added table component #662

Merged
merged 8 commits into from
Oct 27, 2023
Merged

feat: Added table component #662

merged 8 commits into from
Oct 27, 2023

Conversation

albinAppsmith
Copy link
Contributor

@albinAppsmith albinAppsmith commented Oct 24, 2023

Description

This PR adds table component to ADS v2. Table component will be using ec-table internally.

Fixes appsmithorg/appsmith#27771

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Manual on storybook
  • Manual on main repo
  • Jest
  • Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

QA activity:

  • Test plan has been approved by relevant developers
  • Test plan has been peer reviewed by QA
  • Cypress test cases have been added and approved by either SDET or manual QA
  • Organized project review call with relevant stakeholders after Round 1/2 of QA
  • Added Test Plan Approved label after reveiwing all Cypress test

@changeset-bot
Copy link

changeset-bot bot commented Oct 24, 2023

⚠️ No Changeset found

Latest commit: 0753e7a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
design-system ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2023 8:36am

Copy link

@KelvinOm KelvinOm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something is wrong with the table header.
Снимок экрана 2023-10-24 в 18 06 43

packages/design-system/src/Table/Table.styles.tsx Outdated Show resolved Hide resolved
@@ -0,0 +1,55 @@
.rc-table.ads-v2-table-wrapper {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not keep all styles in one place? You already have classes for all these overrides. I think it's better to move.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the reason for doing this here is, RC adds some divs on the fly and the classes we add is not applied on these. That's why I had to keep a seperate CSS file for this.

packages/design-system/src/Table/Table.tsx Outdated Show resolved Hide resolved
KelvinOm
KelvinOm previously approved these changes Oct 25, 2023
@ghost
Copy link

ghost commented Oct 26, 2023

@albinAppsmith
Following are checked on DS repo here and no issue found during testing

  • Header height, { can ignore row height since it depends on content}
  • Header color
  • Header font styles
  • Props: columns, data, sticky, emptyText
  • border colors (every row have a border bottom)

@albinAppsmith albinAppsmith merged commit 2d7607a into release Oct 27, 2023
5 checks passed
@albinAppsmith albinAppsmith deleted the table-component branch October 27, 2023 12:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Add table component to design system
3 participants