Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Release Prepare Experience (Interactive Version Updates) #5594

Open
tisonkun opened this issue Feb 2, 2025 · 1 comment
Open

Better Release Prepare Experience (Interactive Version Updates) #5594

tisonkun opened this issue Feb 2, 2025 · 1 comment
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed release

Comments

@tisonkun
Copy link
Member

tisonkun commented Feb 2, 2025

I'd considering an interactive experience like cargo-release, that prompt package versions one by one and ask the release manager to input the correct version. Then commit the updates as well as generate a release list.

Perhaps pick up in the next month.

Originally posted by @tisonkun in #5592 (comment)

@tisonkun tisonkun added good first issue Good for newcomers help wanted Extra attention is needed release labels Feb 2, 2025
@Xuanwo Xuanwo self-assigned this Feb 2, 2025
@Xuanwo
Copy link
Member

Xuanwo commented Feb 2, 2025

I'm interested in implementing this.


I don't want it to be interactive. I'm not comfortable with requiring every release manager to operate things through a TUI. My current idea is to generate something like the following (the format doesn't matter; plain text or TSV both work well):

core 0.51.0 -> 0.51.2
bindings/python 0.44.0 -> 0.45.0
...

Let's call this a release plan. Users can edit this plan however they want. Once the release plan has been discussed and reviewed, the release manager can run just release run to execute the plan, similar to how we currently use just update-version and just release.

The workflow will be:

  • just release plan -> a default release plan generated with all projects bumps a patch version.
  • The plan will be saved to dist/release_plan.txt and print to console.
  • RM will add this release plan in the tracking issues and discussion thread.
  • After this release plan approved, RM and start a PR (it's also fine to discuss in the PR directly)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed release
Projects
None yet
Development

No branches or pull requests

2 participants