From 5802485c89f429c6089dccd6590e06cf342f534f Mon Sep 17 00:00:00 2001 From: Patrick Druley Date: Mon, 2 Aug 2021 12:56:37 -0400 Subject: [PATCH 1/2] MINOR: doc change for minisr --- core/src/main/scala/kafka/server/KafkaConfig.scala | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/core/src/main/scala/kafka/server/KafkaConfig.scala b/core/src/main/scala/kafka/server/KafkaConfig.scala index 703d796f4326d..13c4b68545e80 100755 --- a/core/src/main/scala/kafka/server/KafkaConfig.scala +++ b/core/src/main/scala/kafka/server/KafkaConfig.scala @@ -826,10 +826,11 @@ object KafkaConfig { "a write for the write to be considered successful. If this minimum cannot be met, " + "then the producer will raise an exception (either NotEnoughReplicas or " + "NotEnoughReplicasAfterAppend).
When used together, min.insync.replicas and acks " + - "allow you to enforce greater durability guarantees. A typical scenario would be to " + + "allow you to enforce greater durability guarantees. The leader and its followers are " + + "all considered replicas so a typical scenario would be to " + "create a topic with a replication factor of 3, set min.insync.replicas to 2, and " + "produce with acks of \"all\". This will ensure that the producer raises an exception " + - "if a majority of replicas do not receive a write." + "if a majority of replicas (2) do not receive a write." val CreateTopicPolicyClassNameDoc = "The create topic policy class that should be used for validation. The class should " + "implement the org.apache.kafka.server.policy.CreateTopicPolicy interface." From 0002907f0f5b6871fd1836323e5dc19bbdee2388 Mon Sep 17 00:00:00 2001 From: Patrick Druley Date: Wed, 4 Aug 2021 16:06:59 -0400 Subject: [PATCH 2/2] Update core/src/main/scala/kafka/server/KafkaConfig.scala Co-authored-by: Joel Hamill <11722533+joel-hamill@users.noreply.github.com> --- core/src/main/scala/kafka/server/KafkaConfig.scala | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/src/main/scala/kafka/server/KafkaConfig.scala b/core/src/main/scala/kafka/server/KafkaConfig.scala index 13c4b68545e80..38c8ee2b93eb3 100755 --- a/core/src/main/scala/kafka/server/KafkaConfig.scala +++ b/core/src/main/scala/kafka/server/KafkaConfig.scala @@ -830,7 +830,7 @@ object KafkaConfig { "all considered replicas so a typical scenario would be to " + "create a topic with a replication factor of 3, set min.insync.replicas to 2, and " + "produce with acks of \"all\". This will ensure that the producer raises an exception " + - "if a majority of replicas (2) do not receive a write." + "if a majority of replicas, in this case 2, do not receive a write." val CreateTopicPolicyClassNameDoc = "The create topic policy class that should be used for validation. The class should " + "implement the org.apache.kafka.server.policy.CreateTopicPolicy interface."