Investigate DMN TCK failures in Drools

[baldimir]

Investigate Drools TCK failures that are highlighted here https://github.com/dmn-tck/tck/pull/566/files#diff-54ac8863a31a3ff3c46c9cc4a6a64f66db0fc1593b6d8dd846c26422c8d384abL1179 (those that switched from SUCCESS to ERROR)

Initial status with 999-SNAPSHOT version: [ERROR] Tests run: 6368, Failures: 0, Errors: 86, Skipped: 0
Current status with 999-SNAPSHOT version: [ERROR] Tests run: 6674, Failures: 0, Errors: 28, Skipped: 0

• It's not possibile to sum or subtract a time in 10:30:00@Europe/Rome format #1323 (12 tests fixed)
• In functions with a scale parameter, that must be in the range [−6111..6176] #1325 (8 tests fixed)
• Filter, Some and Every expression should fail when the matching function doesn't return a Boolean #1326 (6 tests fixed)
• FEEL functions that expect List parameters, should coerce single item to a List #1330 (8 tests fixed)
• It shouldn't be possible to add\subtract a DateTime with a number #1345 (2 tests fixed)
• The for loop wrongly behaves when there are nested arrays in the iteration contexts #1350 (Will fix 1 test)
• DMN Elements with null IDs are not correctly managed  #1356 (24 tests fixed)
• The context function should throw an error when providing objects with the same keys #1367 (1 test fixed)
• matches() function wrongly behaves - checks and unicode #1409 (5 tests fixed)
• It's not possible to refer to an external nodes in informationRequirement and knowledgeRequirement #1411 (1 test fixed)
• matches() function wrongly behaves #1448 (10 tests fixed)
• Passing an incorrect type value as single input of a Decision Services should lead to an error #1410 (Will fix 1 test)
• DMN engine doesn't support generic range type #1536
• DMN TCK failure: range equality test fail for unary test ranges #1546 (Will fix 4 tests)
• Fix TCK tests failing because of a compilation failure #1646
• Return a list of dates instead of a range #1743 (Will fix 6 tests)
• Don't fail a range comparison in FEEL when a unary test range is used #1744 (Will fix 3 tests)
• Passing built-in functions as function's parameters doesn't work #1752 (Will fix 1 test)
• Type cast error when a FEEL expression with mixed types are executed #1771 (Will fix 4 tests)
• Time-based format output (12:12:12) returns no-seconds when they're equal to 00 (eg. 10:00:00 returns 10:00) (Will fix 2 test) - Not converted to a ticket because we are not going to manage that

Nice to have:

• DMN - Fix DroolsTCKTest error expected management #1415

Acceptance criteria:

• The highlighted tests as new errors pass.

[baldimir]

This issue is related to the failures from TCK tests #69

[tiagobento]

@yesamer Thank you for looking into this! If I may, can you please help me understand these two points?

1. Why we're not tackling the last bullet-point Time-based format output (12:12:12) returns no-seconds when they're equal to 00 (eg. 10:00:00 returns 10:00) (Will fix 2 test2)?
2. Is there any place describing how to execute the DMN TCK tests for us? Would be good to plan a periodic execution to see if we didn't introduce any regressions...

[yesamer]

@tiagobento

1. It seems that DMN 1.6 will revisit the time/date specifications. We agreed with @baldimir and @gitgabrio to temporarily keep that point on hold for that reason.
2. We can run them in the TCK repo https://github.com/dmn-tck/tck/tree/master/runners. But it should be possible to run them on drools side too. Once we fix all of them, I would like to run them at every PR that touches DMN-related code.