Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MetricLogUtils forcibly uses Micrometer when available in classpath #6053

Closed
tkobayas opened this issue Aug 22, 2024 · 0 comments · Fixed by #6054
Closed

MetricLogUtils forcibly uses Micrometer when available in classpath #6053

tkobayas opened this issue Aug 22, 2024 · 0 comments · Fixed by #6054

Comments

@tkobayas
Copy link
Contributor

tkobayas commented Aug 22, 2024

https://kie.zulipchat.com/#narrow/stream/232677-drools/topic/Spring.20Batch.20Metrics

MetricLogUtils looks for io.micrometer.core.instrument.Tag. If it exists, micrometerAvailable is set to true.

https://github.com/apache/incubator-kie-drools/blob/main/drools-metric/src/main/java/org/drools/metric/util/MetricLogUtils.java#L42-L50

Then, MetricLogUtils automatically uses Micrometer and doesn't print trace logging.

https://github.com/apache/incubator-kie-drools/blob/main/drools-metric/src/main/java/org/drools/metric/util/MetricLogUtils.java#L95-L99

It's not good for users who have Micrometer, but want to review trace logging.

Let's introduce a flag to choose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🎯 Done
Development

Successfully merging a pull request may close this issue.

1 participant