Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Display audit information for roles, users and groups in Gravitino CLI #5527

Closed
justinmclean opened this issue Nov 10, 2024 · 4 comments · Fixed by #5802
Closed

[Improvement] Display audit information for roles, users and groups in Gravitino CLI #5527

justinmclean opened this issue Nov 10, 2024 · 4 comments · Fixed by #5802
Assignees
@justinmclean
Labels
0.8.0 Release v0.8.0 good first issue Good for newcomers improvement Improvements on everything

Comments

@justinmclean
Copy link
Member

What would you like to be improved?

Similar to #5477 display audit information for users and groups.

How should we improve?

See above.
@justinmclean justinmclean added good first issue Good for newcomers improvement Improvements on everything labels Nov 10, 2024
@Pjaygit
Copy link

Pjaygit commented Nov 12, 2024

@justinmclean can I try working on this?

@justinmclean
Copy link
Member Author

justinmclean commented Nov 12, 2024 •
edited
Loading

Sure, looking at the existing audit command, which should show you what needs to be done, but if you need any help please ask.

@justinmclean
Copy link
Member Author

@Pjaygit how are you going with this?

@justinmclean
Copy link
Member Author

@Pjaygit I going to assume from the lack of response you are no longer working on this. If anyone else want to work on this just ask.

@justinmclean justinmclean changed the title [Improvement] Display audit information for users and groups in Gravitino CLI [Improvement] Display audit information for roles, users and groups in Gravitino CLI Dec 9, 2024
@justinmclean justinmclean self-assigned this Dec 9, 2024
@justinmclean justinmclean mentioned this issue Dec 9, 2024
Merged
shaofengshi pushed a commit that referenced this issue Dec 17, 2024
@justinmclean
[#5527] Add audit command to roles, users and groups in the Gravitino…
71005e7 
… CLI (#5802)

### What changes were proposed in this pull request?

Added audit command to roles, users and groups in the Gravitino CLI.

### Why are the changes needed?

So all entities support the audit command.

Fix: #5527

### Does this PR introduce _any_ user-facing change?

No, but add more commands.

### How was this patch tested?

Tested locally.
@jerryshao jerryshao added the 0.8.0 Release v0.8.0 label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@justinmclean justinmclean

Labels
0.8.0 Release v0.8.0 good first issue Good for newcomers improvement Improvements on everything
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#5527] Add audit command to roles, users and groups in the Gravitino CLI justinmclean/gravitino
3 participants
@justinmclean @jerryshao @Pjaygit