Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FirstValue / LastValue performance optimisations #14215

Open
blaginin opened this issue Jan 20, 2025 · 1 comment
Open

FirstValue / LastValue performance optimisations #14215

blaginin opened this issue Jan 20, 2025 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@blaginin
Copy link
Contributor

Is your feature request related to a problem or challenge?

FirstValue and LastValue can be faster!

  1. When ignore nulls is passed, we sort groups, although getting just the first/last non-null value would be enough.
  2. Without ignore nulls, there's still some small overhead that can be removed. For example, creating a row buffer for each row in our group.
  3. For some primitive types, we can implement GroupsAccumulator similarly to Min/Max.

Describe the solution you'd like

No response

Describe alternatives you've considered

No response

Additional context

No response

@blaginin blaginin added the enhancement New feature or request label Jan 20, 2025
@blaginin
Copy link
Contributor Author

take

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant