Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate datafusion.execution.parquet.max_statistics_size config option #14172

Open
alamb opened this issue Jan 17, 2025 · 1 comment · May be fixed by #14188
Open

Deprecate datafusion.execution.parquet.max_statistics_size config option #14172

alamb opened this issue Jan 17, 2025 · 1 comment · May be fixed by #14188
Labels
enhancement New feature or request

Comments

@alamb
Copy link
Contributor

alamb commented Jan 17, 2025

Is your feature request related to a problem or challenge?

The most recent version of arrow deprecates the max_statistics_size parquet option

You can see the rationale from @etseidl here (it was being silently ignored)

DataFusion also exposes this setting:
https://datafusion.apache.org/user-guide/configs.html

datafusion.execution.parquet.max_statistics_size 4096 (writing) Sets max statistics size for any column. If NULL, uses default parquet writer setting

We should deprecate it as well prior to removal

Describe the solution you'd like

  1. Mark the option deprecated in comments
  2. Make the field deprecated in the code

The config option is defined in two places:
https://github.com/apache/datafusion/blob/04b6d4d6099f537de91e1b30a391bdfbc3ec36d5/datafusion/common/src/config.rs#L1723-L1722
https://github.com/apache/datafusion/blob/04b6d4d6099f537de91e1b30a391bdfbc3ec36d5/datafusion/common/src/config.rs#L1723-L1722

But I think they are done via macro

Describe alternatives you've considered

We can just wait until the field is removed upstream in arrow and yank it from datafusion too

Additional context

No response

@logan-keede
Copy link

Hi @alamb, Please check if my PR #14175 correctly addresses this issue
Thanks,
Logan

@logan-keede logan-keede linked a pull request Jan 18, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants