Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't specify light theme on Android #129

Open
goffioul opened this issue Aug 9, 2019 · 0 comments
Open

Don't specify light theme on Android #129

goffioul opened this issue Aug 9, 2019 · 0 comments

Comments

@goffioul
Copy link

goffioul commented Aug 9, 2019

The dialogs plugin on Android has the light theme hardcoded. I think the plugin shouldn't try to guess what's best, and let the app and/or the platform decide the theme the apply (usually based on the default device theme and the target SDK of the app). Is there a good reason for the dialogs plugin to assume that using the light theme unconditionally is the right way to go?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@goffioul