Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Network 'not found' when displaynetwork=false even when logged in as admin #9386

Open
kohrar opened this issue Jul 12, 2024 · 2 comments · May be fixed by #10209
Open

UI: Network 'not found' when displaynetwork=false even when logged in as admin #9386

kohrar opened this issue Jul 12, 2024 · 2 comments · May be fixed by #10209
Assignees
@harikrishna-patnala
Labels
affects:4.19.0 type:improvement
Milestone
4.19.2

Comments

@kohrar
Copy link
Contributor

kohrar commented Jul 12, 2024

ISSUE TYPE
  • Bug Report
COMPONENT NAME
UI (?)
CLOUDSTACK VERSION
4.19.0
CONFIGURATION

Standard install

OS / ENVIRONMENT

N/A

SUMMARY

When editing a guest network, you can specify 'Display network' to true or false (defaults to true on the UI). When setting this to false, the network immediately becomes hidden even when logged in as admin.

STEPS TO REPRODUCE
  1. Log in to CloudStack UI as admin
  2. Edit any guest network
  3. Set 'Display network' to false
  4. You will be sent to a 404 page immediately even when logged in as an admin.
EXPECTED RESULTS

The hidden network should still be visible as admin on the web UI and hidden only to end users, as per the API documentation:

displaynetwork: an optional field, whether to the display the network to the end user or not.

ACTUAL RESULTS

The hidden network is hidden to everyone including admins on the web UI. There is no way to unhide the network as a result unless you interact with the API / CloudMonkey directly.
@DaanHoogland DaanHoogland added this to the 4.19.2.0 milestone Jul 13, 2024
@rohityadavcloud
Copy link
Member

@kohrar this is by design; you need to pass the displaynetwork=true in the cmk/API which only the root-admin can pass. As a UI hack you can in the network URL, pass this; for example: http://<mgmt server domain/IPO>:8080/client/#/guestnetwork?page=1&pagesize=20&displaynetwork=true

@kohrar
Copy link
Contributor Author

kohrar commented Jul 15, 2024

@rohityadavcloud Thanks for that tip. I can see the network being listed if I pass in displaynetwork=false via the URL.

It still would be nice from a user-experience standpoint if:

  1. the admin interface listed all networks, regardless of displaynetwork's setting.
  2. the admin interface can view/edit networks that are set to displaynetwork=false.

At the moment, it's possible to change displaynetwork=false via the UI and then have no way to revert setting displaynetwork=false from the same UI. Without digging into understanding the API, this may be confusing and prone to CloudStack installations with hidden networks that admins aren't aware of.

@harikrishna-patnala harikrishna-patnala linked a pull request Jan 20, 2025 that will close this issue
Open
12 tasks
@harikrishna-patnala harikrishna-patnala self-assigned this Jan 20, 2025
@harikrishna-patnala harikrishna-patnala moved this from Todo to ready for Testing in Apache CloudStack BugFest - Issues Jan 20, 2025
@harikrishna-patnala harikrishna-patnala moved this from ready for Testing to ready for Review in Apache CloudStack BugFest - Issues Jan 20, 2025
@harikrishna-patnala harikrishna-patnala linked a pull request Jan 20, 2025 that will close this issue
Added displaynetwork option in filters for listnetwork only for admin #10209
Open
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@harikrishna-patnala harikrishna-patnala

Labels
affects:4.19.0 type:improvement
Projects
Apache CloudStack BugFest - Issues
Status: ready for Review
Milestone
4.19.2
Development

Successfully merging a pull request may close this issue.

Added displaynetwork option in filters for listnetwork only for admin shapeblue/cloudstack
4 participants
@rohityadavcloud @DaanHoogland @harikrishna-patnala @kohrar