Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup VM IP after expunge in redundant VPC #10183

Open
wants to merge 2 commits into
base: 4.19
Choose a base branch
from
Open

cleanup VM IP after expunge in redundant VPC #10183

wants to merge 2 commits into from
+1 −2

Conversation

DaanHoogland
Copy link
Contributor

Description

This PR...

Fixes: #10182

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@DaanHoogland DaanHoogland added this to the 4.19.2 milestone Jan 14, 2025
@boring-cyborg boring-cyborg bot added component:virtual-router Python Warning... Python code Ahead! labels Jan 14, 2025
@DaanHoogland DaanHoogland linked an issue Jan 14, 2025 that may be closed by this pull request
Expunge vm not release in-memory dhcp record in vpc redundant virtual route correctly #10182
Open
@DaanHoogland
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@codecov Codecov
Copy link

codecov bot commented Jan 14, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.13%. Comparing base (35fe19f) to head (ecb725f).

Additional details and impacted files 
@@            Coverage Diff            @@
##               4.19   #10183   +/-   ##
=========================================
  Coverage     15.13%   15.13%           
- Complexity    11272    11275    +3     
=========================================
  Files          5408     5408           
  Lines        473958   473958           
  Branches      57811    57811           
=========================================
+ Hits          71721    71743   +22     
+ Misses       394219   394199   -20     
+ Partials       8018     8016    -2
Flag Coverage Δ
uitests 4.30% <ø> (ø)
unittests 15.85% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DaanHoogland DaanHoogland mentioned this pull request Jan 14, 2025
Open
@DaanHoogland DaanHoogland changed the title add workaround from issue reporter cleanup VM IP after expunge in redundant VPC Jan 14, 2025
@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12081

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12083

@DaanHoogland
Copy link
Contributor Author

@blueorangutan test

@blueorangutan
Copy link

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian Build Failed (tid-12108)

@weizhouapache
Copy link
Member

@blueorangutan test

@blueorangutan
Copy link

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-12134)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 51304 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10183-t12134-kvm-ol8.zip
Smoke tests completed. 133 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

weizhouapache
weizhouapache approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@DaanHoogland DaanHoogland marked this pull request as ready for review January 21, 2025 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weizhouapache weizhouapache weizhouapache approved these changes

Assignees
No one assigned
Labels
component:networking component:virtual-router Python Warning... Python code Ahead! status:needs-testing
Projects
None yet
Milestone
4.19.2
Development

Successfully merging this pull request may close these issues.

Expunge vm not release in-memory dhcp record in vpc redundant virtual route correctly
3 participants
@DaanHoogland @blueorangutan @weizhouapache