Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task]: Support non-ascii BigQuery table name #33920

Open
1 of 17 tasks
Abacn opened this issue Feb 7, 2025 · 2 comments
Open
1 of 17 tasks

[Task]: Support non-ascii BigQuery table name #33920

Abacn opened this issue Feb 7, 2025 · 2 comments
Labels
awaiting triage bigquery good first issue java P2 task

Comments

@Abacn
Copy link
Contributor

Abacn commented Feb 7, 2025 •
edited
Loading

What needs to happen?

BigQuery already support non-ascii table names: https://cloud.google.com/bigquery/docs/tables#table_naming

The following are all examples of valid table names: table 01, ग्राहक, 00_お客様, étudiant-01.

However, in Beam BigQueryIO, the table names are guarded by a "\w+" regex:

beam/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryHelpers.java

Line 451 in f03e0c0

if (!match.matches()) {

beam/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIO.java

Line 590 in f03e0c0

private static final String TABLE_REGEXP = "[-\\w$@ ]{1,1024}";

Issue Priority

Priority: 2 (default / most normal work should be filed as P2)

Issue Components

  • Component: Python SDK
  • Component: Java SDK
  • Component: Go SDK
  • Component: Typescript SDK
  • Component: IO connector
  • Component: Beam YAML
  • Component: Beam examples
  • Component: Beam playground
  • Component: Beam katas
  • Component: Website
  • Component: Infrastructure
  • Component: Spark Runner
  • Component: Flink Runner
  • Component: Samza Runner
  • Component: Twister2 Runner
  • Component: Hazelcast Jet Runner
  • Component: Google Cloud Dataflow Runner
@manojks1999
Copy link

@Abacn can I work on this ?

@Abacn
Copy link
Contributor Author

Abacn commented Feb 8, 2025

thanks, feel free to open a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
awaiting triage bigquery good first issue java P2 task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Abacn @manojks1999