Calculate byte size via sampling in StateBackedIterable if size is not cheap to calculate #33780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Assigning reviewers. If you would like to opt out of this review, comment R: @damondouglas for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
scwhittle
requested changes
Feb 3, 2025
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/state/StateBackedIterable.java
Outdated
Show resolved
Hide resolved
sdks/java/harness/src/test/java/org/apache/beam/fn/harness/state/StateBackedIterableTest.java
Outdated
Show resolved
Hide resolved
|
Run Java_PVR_Flink_Docker PreCommit |
scwhittle
requested changes
Feb 3, 2025
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/state/StateBackedIterable.java
Outdated
Show resolved
Hide resolved
|
Run Java PreCommit |
scwhittle
approved these changes
Feb 4, 2025
scwhittle
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Dataflow V2, StateBackedIterable is iterated by readers after gbk shuffle. Examples are ParDo after GBK or merging combiners after GBK.
metrics.proto specifies that Sampling is used because calculating the byte count involves serializing the elements which is CPU intensive.
In case of StateBackedIterable sampling is not occurring which impacts performance of some of the pipelines that have expensive coders.
This change introduces sampling.
Fully fixes #33620 as previous fix was improvement.