Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Remove remaining clcache occurrences #45178

Closed
pitrou opened this issue Jan 6, 2025 · 2 comments
Closed

[CI] Remove remaining clcache occurrences #45178

pitrou opened this issue Jan 6, 2025 · 2 comments
Assignees
@kou
Labels
Component: Continuous Integration Type: enhancement
Milestone
19.0.0

Comments

@pitrou
Copy link
Member

pitrou commented Jan 6, 2025

Describe the enhancement requested

We don't use clcache anymore (on Windows), but there are still a couple places mentioning it:

./ci/scripts/python_wheel_windows_build.bat
103:    -DCMAKE_CXX_COMPILER=clcache ^

./docker-compose.yml
203:  python-wheel-windows-clcache:
204:    name: python-wheel-windows-clcache
1284:      - "${DOCKER_VOLUME_PREFIX}python-wheel-windows-clcache:C:/clcache"

Component(s)

Continuous Integration
kou added a commit to kou/arrow that referenced this issue Jan 6, 2025
@kou
apacheGH-45178: [CI] Remove clcache related codes
d97f9f0 
We don't use clcache anymore.
@github-actions github-actions bot mentioned this issue Jan 6, 2025
Merged
assignUser pushed a commit that referenced this issue Jan 7, 2025
@kou
GH-45178: [CI] Remove clcache related codes (#45182)
8cff21f 
### Rationale for this change

We don't use clcache anymore.

### What changes are included in this PR?

Remove clcache related codes in files except `CHANGELOG.md`:

```console
$ git grep clcache
CHANGELOG.md:* [ARROW-3167](https://issues.apache.org/jira/browse/ARROW-3167) - [CI] Limit clcache cache size
CHANGELOG.md:* [ARROW-2231](https://issues.apache.org/jira/browse/ARROW-2231) - [CI] Use clcache on AppVeyor for faster builds
CHANGELOG.md:* [ARROW-2238](https://issues.apache.org/jira/browse/ARROW-2238) - [C++] Detect and use clcache in cmake configuration
ci/docker/python-wheel-windows-vs2019.dockerfile:# ENV CLCACHE_DIR="C:\clcache"
ci/docker/python-wheel-windows-vs2019.dockerfile:# RUN pip install git+https://github.com/Nuitka/clcache.git
ci/scripts/python_wheel_windows_build.bat:    -DCMAKE_CXX_COMPILER=clcache ^
docker-compose.yml:  python-wheel-windows-clcache:
docker-compose.yml:    name: python-wheel-windows-clcache
docker-compose.yml:      - "${DOCKER_VOLUME_PREFIX}python-wheel-windows-clcache:C:/clcache"
docker-compose.yml:      - "${DOCKER_VOLUME_PREFIX}python-wheel-windows-clcache:C:/clcache"
```

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* GitHub Issue: #45178

Authored-by: Sutou Kouhei <[email protected]>
Signed-off-by: Jacob Wujciak-Jens <[email protected]>
@assignUser
Copy link
Member

Issue resolved by pull request 45182
#45182

@assignUser assignUser added this to the 19.0.0 milestone Jan 7, 2025
@pitrou
Copy link
Member Author

pitrou commented Jan 7, 2025 •
edited
Loading

Thanks @assignUser !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kou kou

Labels
Component: Continuous Integration Type: enhancement
Projects
None yet
Milestone
19.0.0
Development

No branches or pull requests
3 participants
@kou @pitrou @assignUser