Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R] Fix failing windows build on CI #38906

Closed
paleolimbot opened this issue Nov 28, 2023 · 1 comment · Fixed by #38927
Closed

[R] Fix failing windows build on CI #38906

paleolimbot opened this issue Nov 28, 2023 · 1 comment · Fixed by #38927
Assignees
@paleolimbot
Labels
Component: R Type: bug
Milestone
15.0.0

Comments

@paleolimbot
Copy link
Member

Describe the bug, including details regarding any error messages, version, and platform.

Follow-up on #38894 (comment) :

The Windows R-devel build is failing on CI because one of our dependencies (cpp11) has an invalid format string in a rarely-used function in its header ( r-lib/cpp11#345 ) and we convert all errors to warnings (apparently, according to the output).

To fix this we can:

  • Not test r-devel on Windows for every commit (and ensure we do so on nightly, which I'm pretty sure we do, but worth checking before removing this job)
  • Find where we convert warnings to errors and stop doing that
  • Check to see if some other flag is causing this to occur (maybe -O0?)

I don't think we can or should wait for the PR linked above to merge upstream since this is causing CI to fail for all R PRs.

cc @assignUser

Component(s)

R
@assignUser
Copy link
Member

I think disabling until that PR is merged is fine?

@github-actions github-actions bot mentioned this issue Nov 28, 2023
Merged
paleolimbot added a commit that referenced this issue Nov 29, 2023
@paleolimbot
GH-38906: [R] Improve Windows CI configuration (#38927)
72d0969 
### Rationale for this change

The Windows/R-devel job is causing CI to fail on many PRs that are unrelated to Windows/R-devel. We also have some outdated version numbers in the Windows action.

### What changes are included in this PR?

The version for Windows was updated to "release", which should keep it current without explicit maintenance (since clearly we had forgotten to update the version numbers ourselves 😬 ). The devel version was removed because (1) it is failing and won't stop failing until an upstream PR to cpp11 is merged and (2) it's unclear to me that this check adds anything useful (we already test r-devel in another commit-level job). It may have dated from a time that r-devel on Windows was much different than r-release (it no longer is).

### Are these changes tested?

Yes

### Are there any user-facing changes?

No
* Closes: #38906

Authored-by: Dewey Dunnington <[email protected]>
Signed-off-by: Dewey Dunnington <[email protected]>
@paleolimbot paleolimbot added this to the 15.0.0 milestone Nov 29, 2023
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@paleolimbot @dgreiss
apacheGH-38906: [R] Improve Windows CI configuration (apache#38927)
5af11c2 
### Rationale for this change

The Windows/R-devel job is causing CI to fail on many PRs that are unrelated to Windows/R-devel. We also have some outdated version numbers in the Windows action.

### What changes are included in this PR?

The version for Windows was updated to "release", which should keep it current without explicit maintenance (since clearly we had forgotten to update the version numbers ourselves 😬 ). The devel version was removed because (1) it is failing and won't stop failing until an upstream PR to cpp11 is merged and (2) it's unclear to me that this check adds anything useful (we already test r-devel in another commit-level job). It may have dated from a time that r-devel on Windows was much different than r-release (it no longer is).

### Are these changes tested?

Yes

### Are there any user-facing changes?

No
* Closes: apache#38906

Authored-by: Dewey Dunnington <[email protected]>
Signed-off-by: Dewey Dunnington <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paleolimbot paleolimbot

Labels
Component: R Type: bug
Projects
None yet
Milestone
15.0.0
Development

Successfully merging a pull request may close this issue.

GH-38906: [R] Improve Windows CI configuration paleolimbot/arrow
2 participants
@paleolimbot @assignUser