Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release] How to create release note? #499

Open
kou opened this issue Jan 10, 2025 · 18 comments
Open

[Release] How to create release note? #499

kou opened this issue Jan 10, 2025 · 18 comments
Labels
Type: enhancement New feature or request

Comments

@kou
Copy link
Member

kou commented Jan 10, 2025

Describe the enhancement requested

From #496 (comment) :

I suppose we should consider something like conventional commits for this repo too? Or else manually curate a CHANGELOG.md?

@kou kou added the Type: enhancement New feature or request label Jan 10, 2025
@kou
Copy link
Member Author

kou commented Jan 10, 2025

@wgtmac Do you have any preference for this?

@lidavidm
Copy link
Member

I have a slight preference for conventional commits given we use it on go and ADBC. But we could keep the existing format and just write a script to scrape commits and make a basic changelog too.

@wgtmac
Copy link
Member

wgtmac commented Jan 10, 2025

Is there any benefit from conventional commits to create release note? @lidavidm

I don't have a preference yet. I used JIRA to create release note for Apache ORC and Apache Parquet (before switching to Github issue) which is convenient.

I am not sure if we can leverage this to customize it: https://docs.github.com/en/repositories/releasing-projects-on-github/automatically-generated-release-notes

@lidavidm
Copy link
Member

The GitHub generation looks interesting. Why don't we try it out?

Conventional commits is basically just a common standard. It's not too different from the existing convention, just instead of [CI] or [C++] it's chore(ci): ... or feat(c++): ...

@kou
Copy link
Member Author

kou commented Jan 10, 2025

OK. Let's try it for the next release.
We can revisit this after the next release.

@lidavidm
Copy link
Member

I think we'll need to set up some labels, and then probably some automation to ensure labels are applied to PRs. Maybe to start with just breaking-change, bug-fix, and enhancement categories, and an action that asks for at least one of the three to be set?

@lidavidm
Copy link
Member

@kou @jbonofre do we want to get this done before the release? Or will we just use the default changelog for now?

@jbonofre
Copy link
Member

@kou @jbonofre do we want to get this done before the release? Or will we just use the default changelog for now?

Both is ok for me. But clearly it has to be fixed.

@lidavidm
Copy link
Member

If those three tags are OK, I can set them up real quick and go back and tag PRs (maybe also a chore tag for things like CI/release processes)

@jbonofre
Copy link
Member

FYI, on Apache Camel, we just use GitHub Milestone link. Maybe we can start from there ?

@lidavidm
Copy link
Member

Right, that's what I meant by "default changelog", GitHub just puts all the commits into the milestone. If that's ok then feel free to proceed.

I'd like to do a bit of categorization eventually though since a changelog of just "bump dependency" is a bit cluttered and not very useful.

@jbonofre
Copy link
Member

Yes, and also maybe we can also create some "manual" GitHub Issues on the target milestone (if it helps the end users).

@lidavidm
Copy link
Member

I believe the changelog will just use commit messages since the base tag

@kou
Copy link
Member Author

kou commented Jan 30, 2025

Ah, we may need to write a release note for 18.2.0 manually. Because there is no base tag now...

@lidavidm
Copy link
Member

Right, that's why I asked if we should just push a base tag to use

@jbonofre
Copy link
Member

Yup, as said on this other issue, I will do a git log to create issues for this milestone.

@lidavidm
Copy link
Member

I don't think we need to backfill issues necessarily...One, we already have issues for most PRs (we only don't have them for MINOR PRs)

@lidavidm
Copy link
Member

I just moved all the completed issues into the milestone as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants