From 9396005b1c31368408af5f6af2600ced1ff64cbb Mon Sep 17 00:00:00 2001 From: Brent Bovenzi Date: Wed, 8 Jan 2025 11:02:49 -0500 Subject: [PATCH] Rename Try Number to Attempt --- airflow/ui/src/components/TaskInstanceTooltip.tsx | 2 +- airflow/ui/src/components/TaskTrySelect.tsx | 4 ++-- airflow/ui/src/pages/Events/Events.tsx | 2 +- airflow/ui/src/pages/Run/TaskInstances.tsx | 2 +- airflow/ui/src/pages/Task/Instances.tsx | 2 +- airflow/ui/src/pages/TaskInstance/Header.tsx | 2 +- 6 files changed, 7 insertions(+), 7 deletions(-) diff --git a/airflow/ui/src/components/TaskInstanceTooltip.tsx b/airflow/ui/src/components/TaskInstanceTooltip.tsx index bc44a23856ffd..8b43ddea3bcfa 100644 --- a/airflow/ui/src/components/TaskInstanceTooltip.tsx +++ b/airflow/ui/src/components/TaskInstanceTooltip.tsx @@ -45,7 +45,7 @@ const TaskInstanceTooltip = ({ children, positioning, taskInstance, ...rest }: P End Date: - {taskInstance.try_number > 1 && Try Number: {taskInstance.try_number}} + {taskInstance.try_number > 1 && Attempt: {taskInstance.try_number}} {"duration" in taskInstance ? ( Duration: {taskInstance.duration?.toFixed(2) ?? 0}s ) : undefined} diff --git a/airflow/ui/src/components/TaskTrySelect.tsx b/airflow/ui/src/components/TaskTrySelect.tsx index 895baac7db139..e84124d3a0f31 100644 --- a/airflow/ui/src/components/TaskTrySelect.tsx +++ b/airflow/ui/src/components/TaskTrySelect.tsx @@ -68,7 +68,7 @@ export const TaskTrySelect = ({ onSelectTryNumber, selectedTryNumber, taskInstan return ( - Task Tries + Attempts {showDropdown ? ( - + {( items: Array<{ task_instance: TaskInstanceHistoryResponse; diff --git a/airflow/ui/src/pages/Events/Events.tsx b/airflow/ui/src/pages/Events/Events.tsx index f93d8a075260b..535309d3ad3a2 100644 --- a/airflow/ui/src/pages/Events/Events.tsx +++ b/airflow/ui/src/pages/Events/Events.tsx @@ -88,7 +88,7 @@ const eventsColumn = ( { accessorKey: "try_number", enableSorting: false, - header: "Try Number", + header: "Attempt", meta: { skeletonWidth: 10, }, diff --git a/airflow/ui/src/pages/Run/TaskInstances.tsx b/airflow/ui/src/pages/Run/TaskInstances.tsx index bbfaa35babef4..4265f07573c39 100644 --- a/airflow/ui/src/pages/Run/TaskInstances.tsx +++ b/airflow/ui/src/pages/Run/TaskInstances.tsx @@ -68,7 +68,7 @@ const columns: Array> = [ { accessorKey: "try_number", enableSorting: false, - header: "Try Number", + header: "Attempt", }, { accessorKey: "operator", diff --git a/airflow/ui/src/pages/Task/Instances.tsx b/airflow/ui/src/pages/Task/Instances.tsx index b9622b3b14108..063b52ba05548 100644 --- a/airflow/ui/src/pages/Task/Instances.tsx +++ b/airflow/ui/src/pages/Task/Instances.tsx @@ -71,7 +71,7 @@ const columns = (isMapped?: boolean): Array> => { accessorKey: "try_number", enableSorting: false, - header: "Try Number", + header: "Attempt", }, { cell: ({ row: { original } }) => `${getDuration(original.start_date, original.end_date)}s`, diff --git a/airflow/ui/src/pages/TaskInstance/Header.tsx b/airflow/ui/src/pages/TaskInstance/Header.tsx index 2eb1228a9aa91..a13892daf5c97 100644 --- a/airflow/ui/src/pages/TaskInstance/Header.tsx +++ b/airflow/ui/src/pages/TaskInstance/Header.tsx @@ -53,7 +53,7 @@ export const Header = ({ taskInstance }: { readonly taskInstance: TaskInstanceRe {taskInstance.map_index > -1 ? ( {taskInstance.rendered_map_index ?? taskInstance.map_index} ) : undefined} - {taskInstance.try_number > 1 ? {taskInstance.try_number} : undefined} + {taskInstance.try_number > 1 ? {taskInstance.try_number} : undefined}