Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AIP-81 Add DAG Report API #45393

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

jason810496
Copy link
Contributor

closes: #45301


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added the area:UI Related to UI/UX. For Frontend Developers. label Jan 4, 2025
@jason810496 jason810496 force-pushed the feature/AIP-81/add-dag-report-api branch from 1b6edc5 to 4b10edf Compare January 4, 2025 16:07
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

Just a few suggestions but looking good overall.

@jason810496 jason810496 force-pushed the feature/AIP-81/add-dag-report-api branch from 4b10edf to 22f8012 Compare January 10, 2025 13:57
@jason810496
Copy link
Contributor Author

All comments have been resolved. Thanks, @pierrejeambrun, for the code review!

Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI needs fixing I think, looking good.

Just a couple of minor nit.

@jason810496 jason810496 force-pushed the feature/AIP-81/add-dag-report-api branch from 26d0d71 to 0b90bda Compare January 15, 2025 22:24
@jason810496
Copy link
Contributor Author

Rebase to latest main.

@jason810496 jason810496 force-pushed the feature/AIP-81/add-dag-report-api branch from 0b90bda to db90345 Compare January 18, 2025 16:29
@jason810496
Copy link
Contributor Author

Hi @pierrejeambrun , I just fixed the broken test due to breaking change on list_py_file__paths.
The CI failure is caused by CodeQL.

@jason810496 jason810496 force-pushed the feature/AIP-81/add-dag-report-api branch from db90345 to 86e5dcb Compare January 20, 2025 16:31
@jason810496 jason810496 force-pushed the feature/AIP-81/add-dag-report-api branch from 86e5dcb to 983c75a Compare January 20, 2025 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AIP-81 Implement DAG Report Endpoint in REST API (FastAPI)
2 participants