Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not assume the user uses bash when installing #4670

Open
ThatOneCalculator opened this issue Jan 28, 2025 · 0 comments
Open

Do not assume the user uses bash when installing #4670

ThatOneCalculator opened this issue Jan 28, 2025 · 0 comments

Comments

@ThatOneCalculator
Copy link

ThatOneCalculator commented Jan 28, 2025

Problem

When installing the Solana CLI (via sh -c "$(curl -sSfL https://release.anza.xyz/stable/install)"), the program assumes the user is using bash, and appends export PATH="$HOME/.local/share/solana/install/active_release/bin:$PATH" to .bash_profile even if the user does not use bash. (Found this issue while installing using the fish shell).

Proposed Solution

  1. If the current $SHELL isn't bash, simply tell the user to add the path manually
  2. If the current $SHELL is another common shell like fish, zsh, etc, properly add the path to the relevant config file, PREFERABLY asking the user if they would like their config file automatically edited (this may be undesired behavior!)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant