Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pushing large files over SCP #661

Open
wants to merge 3 commits into
base: devel
Choose a base branch
from
Open

Fix pushing large files over SCP #661

wants to merge 3 commits into from

Conversation

Jakuje
Copy link
Contributor

@Jakuje Jakuje commented Nov 15, 2024

SUMMARY

The SCP is trying to read the whole file into memory and send it as a whole to the server. This is very prone to hit some memory limits of the machine with larger files.

This changes the implements similar approach to the get() operation as done in #621, including very similar test.

Fixes: #654

ISSUE TYPE
  • Bugfix Pull Request

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Nov 15, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@packit-as-a-service Packit-as-a-Service
Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/ansible-pylibssh-661
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@webknjaz
Copy link
Member

Looks like tests/unit/channel_test.py::test_request_exec times out under Python 3.9 on macOS 13 (and possibly others?)

(https://github.com/ansible/pylibssh/actions/runs/12434120667/job/34717468112?pr=661#step:17:68)

@Jakuje
Copy link
Contributor Author

Jakuje commented Dec 23, 2024

Looks like tests/unit/channel_test.py::test_request_exec times out under Python 3.9 on macOS 13 (and possibly others?)

(https://github.com/ansible/pylibssh/actions/runs/12434120667/job/34717468112?pr=661#step:17:68)

This should be fixed by #658 I hope.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

scp.put fails with large files
2 participants
@Jakuje @webknjaz