Skip to content
This repository has been archived by the owner on May 20, 2024. It is now read-only.

callback plugins require more that a maintainer shipit comment. #1230

Open
rrey opened this issue Jul 14, 2019 · 0 comments
Open

callback plugins require more that a maintainer shipit comment. #1230

rrey opened this issue Jul 14, 2019 · 0 comments
Labels
enhancement governance request is about changing governance and needs discussion

Comments

@rrey
Copy link

rrey commented Jul 14, 2019

Hi,

in bot help page the following can be read for merge conditions on community maintained modules:

If you are maintainer of the module or maintainer of a module in the same namespace, only one shipit is required.

It seems that the behavior is not applied on callback plugins.
Here are 2 PR where I am maintainer of the callback, and my shipit comment was not enough to trigger the bot shipit labeling:
ansible/ansible#57629
ansible/ansible#57575

I had to ask for help on IRC.
Is there a reason for not applying the same merge conditions on callbacks ?

@jctanner jctanner added enhancement governance request is about changing governance and needs discussion labels Jul 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement governance request is about changing governance and needs discussion
Projects
None yet
Development

No branches or pull requests

2 participants