We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
https://github.com/ansasaki/symbol_version/blob/f441d3446bcb325df9a3ae440313d30da2646952/scripts/symbol_version.py#L226-L395
in general, I wonder if first splitting the file into sections for specific versions, and then parsing them wouldn't result in cleaner code
245: combination of strip() and startswith() seems like less heavy-handed approach (and more readable)
strip()
startswith()
In general, I think a lot of the regex calls could be replaced by find(), startswith() or split()
find()
split()
246: comparison to None, in general it should be is not None, in this case it should be just if m:
None
is not None
if m:
The text was updated successfully, but these errors were encountered:
No branches or pull requests
https://github.com/ansasaki/symbol_version/blob/f441d3446bcb325df9a3ae440313d30da2646952/scripts/symbol_version.py#L226-L395
in general, I wonder if first splitting the file into sections for specific versions, and then parsing them wouldn't result in cleaner code
245: combination of
strip()
andstartswith()
seems like less heavy-handed approach (and more readable)In general, I think a lot of the regex calls could be replaced by
find()
,startswith()
orsplit()
246: comparison to
None
, in general it should beis not None
, in this case it should be justif m:
The text was updated successfully, but these errors were encountered: