You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
is it expected that the error does not halt execution?
the warnings talk about numeric versions but the regex will also match alphanumeric versions, like ab.dd.pre1
I don't know how strictly those should be semantic versions, but for those, there's a setuptoolsparse_version() function (not saying it should be used, that depends on 1. 😃 )
that loop can be replaced by list comprehension:
return [int(i) foriinm]
The text was updated successfully, but these errors were encountered:
In the beginning it was supposed to support different version styles (using letters , like 1.0.a). But this was changed because it makes difficult to make the version bump (that is the reason for issue Allow user to configure version bump strategy #20)
Looks good, maybe I'll switch to this implementation
Now I know how to use list comprehensions (and sometimes I remember to use generators)
https://github.com/ansasaki/symbol_version/blob/f441d3446bcb325df9a3ae440313d30da2646952/scripts/symbol_version.py#L55-L73
ab.dd.pre1
setuptools
parse_version()
function (not saying it should be used, that depends on 1. 😃 )The text was updated successfully, but these errors were encountered: