Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent colour of hyperlinks #12595

Closed
4 tasks done
pratyaksh1610 opened this issue Oct 7, 2022 · 6 comments · Fixed by #12662
Closed
4 tasks done

Inconsistent colour of hyperlinks #12595

pratyaksh1610 opened this issue Oct 7, 2022 · 6 comments · Fixed by #12662
Assignees
Milestone

Comments

@pratyaksh1610
Copy link
Contributor

Reproduction Steps

Hyperlinks should follow a color scheme.

  1. Settings -> About
  2. Settings -> About -> Open changelog
Debug info

Refer to the support page if you are unsure where to get the "debug info".

Research

Enter an [x] character to confirm the points below:

  • I have read the support page and am reporting a bug or enhancement request specific to AnkiDroid
  • I have checked the manual and the FAQ and could not find a solution to my issue
  • I have searched for similar existing issues here and on the user forum
  • (Optional) I have confirmed the issue is not resolved in the latest alpha release (instructions)

highlight_links
link_colour_must+be_same

@welcome
Copy link

welcome bot commented Oct 7, 2022

Hello! 👋 Thanks for logging this issue. Please remember we are all volunteers here, so some patience may be required before we can get to the issue. Also remember that the fastest way to get resolution on an issue is to propose a change directly, https://github.com/ankidroid/Anki-Android/wiki/Contributing

@TomerPacific
Copy link
Contributor

Hi @mikehardy , can I help with this issue?

@BrayanDSO
Copy link
Member

I'm not mikehardy, but yes you can. Enjoy working on it

@krmanik
Copy link
Member

krmanik commented Oct 13, 2022

This may be fixed on ankidroiddocs issue because previous image has TexView and later image has html <a> tag in webview for docs.
The changes will be styling the link here for both light and dark theme.

The list of commits to the development version is visible <a href="https://github.com/ankidroid/Anki-Android/commits/main">here</a>.

But I have completed new docs which is consistent with Anki Desktop docs and AnkiMiobile docs.
ankidroid/ankidroiddocs#103

@mikehardy
Copy link
Member

@BrayanDSO

I'm not mikehardy, but yes you can. Enjoy working on it

image

@TomerPacific
Copy link
Contributor

@mikehardy , @BrayanDSO - I have opened a PR and I welcome your feedback.

@github-actions github-actions bot added this to the 2.16 release milestone Oct 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants