Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular type check is not working properly #1553

Open
2 tasks
yossiyedid opened this issue Jan 13, 2025 · 0 comments
Open
2 tasks

Angular type check is not working properly #1553

yossiyedid opened this issue Jan 13, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@yossiyedid
Copy link

yossiyedid commented Jan 13, 2025

Please provide the environment you discovered this bug in.

version - 1.12.0
angular 18
using analog/angular plugin

Which area/package is the issue in?

create-analog

Description

type errors are not displayed, reproduce-
create a service (optional - with property called: 'prop2 = 2')
from component, inject the service, and point to non-existing property like prop1.
no error was shown and Vite still serves the wrong implementation.

after serve refresh (abort and re-serve), the desired error occur.
"Pre-transform error: Property 'prop1' does not exist on type 'AService'. Did you mean 'prop2'?"

Please provide the exception or error you saw

no error occurs with Analogjs. With Angular compiler it does.

Other information

No response

I would be willing to submit a PR to fix this issue

  • Yes
  • No
@yossiyedid yossiyedid added the bug Something isn't working label Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant