From 538e1f5eea8b003bdad13905a42324f9edf8253a Mon Sep 17 00:00:00 2001 From: spatel033 <177532680+spatel033@users.noreply.github.com> Date: Wed, 8 Jan 2025 18:41:59 +0000 Subject: [PATCH] Remove nvm As part of ITHC report removing nvm.sh installation. For API nvm is used to install `squawk-cli` so now installing `squawk-cli` via pip and removing nvm. --- docker/Dockerfile | 13 ------------- requirements_for_test.in | 1 + requirements_for_test.txt | 2 ++ 3 files changed, 3 insertions(+), 13 deletions(-) diff --git a/docker/Dockerfile b/docker/Dockerfile index 419a1d0b41..da54ac30fd 100644 --- a/docker/Dockerfile +++ b/docker/Dockerfile @@ -162,16 +162,3 @@ RUN \ RUN \ service postgresql start \ && su - postgres -c "psql -c \"alter user postgres with password 'postgres';\"" - - -ENV NODE_VERSION=20.10.0 -ENV NVM_VERSION=0.39.7 - -RUN \ - echo "Installing NVM & Node" \ - && curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v${NVM_VERSION}/install.sh | bash \ - && source ~/.nvm/nvm.sh \ - && nvm install $NODE_VERSION \ - && npm install -g squawk-cli@1.1.0 - -ENV PATH=/root/.nvm/versions/node/v${NODE_VERSION}/bin:$PATH diff --git a/requirements_for_test.in b/requirements_for_test.in index 8ea905dde2..fafda26125 100644 --- a/requirements_for_test.in +++ b/requirements_for_test.in @@ -5,3 +5,4 @@ flaky==3.8.0 moto==5.0.11 pytest-httpserver==1.0.8 trustme==0.9.0 +squawk-cli==1.4.0 \ No newline at end of file diff --git a/requirements_for_test.txt b/requirements_for_test.txt index 705847c6af..0159854b9c 100644 --- a/requirements_for_test.txt +++ b/requirements_for_test.txt @@ -366,6 +366,8 @@ sqlalchemy==1.4.41 # alembic # flask-sqlalchemy # marshmallow-sqlalchemy +squawk-cli==1.4.0 + # via -r requirements_for_test.in statsd==4.0.1 # via # -r requirements.txt