Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression - Positional parameters in commandline with ':' #104

Open
nkm8 opened this issue Apr 27, 2020 · 1 comment
Open

Regression - Positional parameters in commandline with ':' #104

nkm8 opened this issue Apr 27, 2020 · 1 comment

Comments

@nkm8
Copy link

nkm8 commented Apr 27, 2020

Re-open #43

This is currently an issue because the original fix (remove ':' as a delimiter): 475e81f#diff-c0a9531e46e016330ce60f8b8de66495R13

Was reverted: https://github.com/aloneguid/config/blob/master/src/Config.Net/Stores/Impl/CommandLine/CommandLineConfigStore.cs#L15

I am not sure if this was intentional or not. I can open a PR, but I am guessing that removing the ':' again isn't desired: e14548b

You can test this by using a positional parameter with a value like C:\temp - you will get null instead of C:\temp for .UseCommandLineArgs(new KeyValuePair<string, int>(nameof(IParameters.FolderPath), 1))

@martin-braun
Copy link

I agree, : is not a well thought parameter in that regards. @aloneguid, can you give some insight how one is supposed to use absolute paths on command args?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants