Skip to content
This repository has been archived by the owner on May 18, 2020. It is now read-only.

Support ElasticSearch 7.0.0 #86

Open
yuriy-slobodchikov opened this issue Apr 11, 2019 · 14 comments
Open

Support ElasticSearch 7.0.0 #86

yuriy-slobodchikov opened this issue Apr 11, 2019 · 14 comments

Comments

@yuriy-slobodchikov
Copy link

yuriy-slobodchikov commented Apr 11, 2019

This is update request.
Please, Support ElasticSearch 7.0.0

@nov1n
Copy link

nov1n commented Apr 12, 2019

This would be great!

Can you say something about how hard it is to add support for the new ES version, and what the expected timeline is?

@yuriy-slobodchikov
Copy link
Author

@nov1n Hello, sorry for not clear state in initial description.
This is update request for Support ElasticSearch 7.0.0
I am using embedded-elasticsearch in projects and would like to use it with ElasticSearch 7.0.0

@yuriy-slobodchikov
Copy link
Author

yuriy-slobodchikov commented Apr 12, 2019

@nov1n
"Can you say something about how hard it is to add support for the new ES version, and what the expected timeline is?"
I dont know) I just created issue to let know contributors that it would be nice to support ElasticSearch 7.0.0

@psk-ixolit
Copy link

@danderson
Copy link

@psk-ixolit I just sent a PR as well. How did you deal with the incompatible changes to indexing and templating APIs? I'm not very happy with my solution, but I couldn't see a better way.

@psk-ixolit
Copy link

psk-ixolit commented Apr 25, 2019

I didn't yet. I have a starting ES 7.0 version which was enough for my usecase. I tried porting the tests, bit didn't finish it.

However I quickly added a jitpack build to it: https://jitpack.io/#psk-ixolit/embedded-elasticsearch

The master snapshot works: https://jitpack.io/com/github/psk-ixolit/embedded-elasticsearch/master-embedded-elasticsearch-2.10.0-ge65deca-5/build.log

dependencies {
   implementation 'com.github.psk-ixolit:embedded-elasticsearch:master-SNAPSHOT'
}

@bsilla
Copy link

bsilla commented May 16, 2019

any chance of seeing this happen soon ?

@sylwester-gk
Copy link

Have you started working on support for ES 7.0? Any progress?

@rdpatil4
Copy link

Thanks for your work. I am waiting for ES 7.x support as well.

@gianvitom
Copy link

I'm also interested in the ES7 support. Any progress so far?

@bsilla
Copy link

bsilla commented Oct 10, 2019

I ended up using elasticsearch-cluster-runner. Works great for my needs, and migration wasn't painful.

@cbromberg
Copy link

cbromberg commented Feb 3, 2020

It worked for me manually downloading from a 7.1.1 OSS URL and renaming the download to drop any name segments after the version number, then the starting worked for me. (To achieve this I had to create pl.allegro... namespaced classes to work around some encapsulation, but in the end I just needed to one class and create one new one)
Didn't need any additional plugins etc., just needed a running instance.
Thought about creating a PR, but from the looks of the Github repo I'd guess the maintainer has deserted this project (thanks for sharing this code anyways). If this repo / dependency is still alive I would be happy to contribute back

@todvora
Copy link
Contributor

todvora commented Apr 28, 2020

We have migrated our integration tests to https://www.testcontainers.org/modules/elasticsearch/. It's quite straightforward to write a few lines long wrapper that will offer similar API as this library.

Thank you ALLEGRO for creating this library and keeping it up-to-date for a very long time. It has kept our integration tests running for several years. And now with testcontainers it's time to move on.

Best regards,
Tomas

@SiwyDym
Copy link

SiwyDym commented Apr 30, 2020

We have migrated our integration tests to https://www.testcontainers.org/modules/elasticsearch/. It's quite straightforward to write a few lines long wrapper that will offer similar API as this library.

Thank you ALLEGRO for creating this library and keeping it up-to-date for a very long time. It has kept our integration tests running for several years. And now with testcontainers it's time to move on.

Best regards,
Tomas

The same, we migrate to testcontainers

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.