Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Form]启用 responsive 后 label 和 input 水平线对不齐 #3999

Closed
guoyunhe opened this issue Jul 18, 2022 · 5 comments · Fixed by #4905
Closed

[Form]启用 responsive 后 label 和 input 水平线对不齐 #3999

guoyunhe opened this issue Jul 18, 2022 · 5 comments · Fixed by #4905
Assignees
@GCHHCG
Labels
🐞 Bug Something isn't working Easy to solve Easy to solve problems, PR welcome Next release issues to close in next release PR welcome We need you to help us by sending a pull request :)

Comments

@guoyunhe
Copy link
Contributor

Component

Form

Reproduction link

https://o2.alibaba-inc.com/sandbox/ide?id=241

Steps to reproduce

image
@YunMeng99
Copy link
Contributor

因长期不活跃关闭，如需继续跟进请重提 issue

@guoyunhe
Copy link
Contributor Author

@YunMeng99 啥叫长期不活跃啊，长期不活跃是指处理的没有跟进，你们长期不处理就叫不活跃吗 😿

@YunMeng99 YunMeng99 reopened this Aug 11, 2023
@YunMeng99
Copy link
Contributor

@guoyunhe 这个bug会继续跟进 昨天看错了 是有点对不齐

@YunMeng99 YunMeng99 added the 🐞 Bug Something isn't working label Aug 11, 2023
@YSMJ1994 YSMJ1994 added Easy to solve Easy to solve problems, PR welcome PR welcome We need you to help us by sending a pull request :) labels Jan 12, 2024
@YSMJ1994
Copy link
Contributor

YSMJ1994 commented Jan 12, 2024 •
edited
Loading

经排查，是 responsive 模式下 label 对齐使用了与普通模式不一样的方式，且该实现方式欠缺考虑（依赖下级 label 高度为其 font-size值），调整为 line-height = element-height 后即可恢复。
我们将改 issue 纳入到 easy to resolve 列表内，欢迎社区同学贡献代码

@eternalsky eternalsky added the Next release issues to close in next release label Jun 25, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in DAILY WORK Jun 25, 2024
@YunMeng99 YunMeng99 self-assigned this Jun 25, 2024
@YunMeng99 YunMeng99 removed their assignment Jul 16, 2024
@GCHHCG GCHHCG self-assigned this Jul 30, 2024
@eternalsky eternalsky linked a pull request Jul 31, 2024 that will close this issue
fix(Form): enabled responsive form should maintain alignment between label and input #4905
Merged
@eternalsky eternalsky moved this from 🆕 New to Ready to release in DAILY WORK Aug 30, 2024
@eternalsky
Copy link
Contributor

已修复，见 https://o2.alibaba-inc.com/sandbox/ide?id=689

@eternalsky eternalsky moved this from Ready to release to ✅ Done in DAILY WORK Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GCHHCG GCHHCG

Labels
🐞 Bug Something isn't working Easy to solve Easy to solve problems, PR welcome Next release issues to close in next release PR welcome We need you to help us by sending a pull request :)
Projects
DAILY WORK
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(Form): enabled responsive form should maintain alignment between label and input GCHHCG/next
6 participants
@bindoon @guoyunhe @eternalsky @YSMJ1994 @GCHHCG @YunMeng99