Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

evaluate websocket implementation #121

Open
alexrudd2 opened this issue Nov 27, 2023 · 0 comments
Open

evaluate websocket implementation #121

alexrudd2 opened this issue Nov 27, 2023 · 0 comments

Comments

@alexrudd2
Copy link
Owner

alexrudd2 commented Nov 27, 2023

I also started investigating https://github.com/robtaussig/react-use-websocket#example-implementation to see if it handles certain things better.

For example, our server uses the entire WebSocket object for identity, so I am unsure if it actually is filtering out when a tab is closed. We should generate an ID client-side and just pass that in as a query parameter, so we can gracefully remove connections that have been terminated.

Originally posted by @jedahan in #89 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant