Husky and lint-staged linting automate tools on pre-commit event #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PixelSculptor
changed the title
marcol13
approved these changes
Aug 26, 2023
| "lint-staged": { | ||
| "./src/**/*.{js,jsx}": "eslint --fix", | ||
| "./src/**/*.{jsx,js,scss}": "prettier --write", | ||
| "./src/**/*.scss": "stylelint --fix" |
There was a problem hiding this comment.
W sumie tutaj takie pytanie. Czy zawsze dla nas --fix będzie pożądany? Automatyczne fixy mogą powodować trochę bałaganu i przed commitem nie jesteśmy w stanie nad nimi zapanować 😅 To potencjalnie będzie powodowało kolejne problemy. Czy ewentualnie jesteśmy w stanie zmienić te fixy na zwykłe --check? Co o tym myślisz @PixelSculptor ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds 2 automate tools:
When you edit files in ui/src that have .js, .jsx or scss extension and then add to stage, all these files will be checked and linted automatically before commit, if eslint detects something wrong, then throws an error and thanks to this we will not push rubbish code and commits and we will fix all before extending our history of repo.