Created lobby view + implemented standard components #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
December 29, 2024 18:05
Open
|
I've made small contribution. Fixed issue with missing disabled attribute on button element, moved clsx dep to client dir, etc. I saw that you currently don't support touch devices in Seat component (i can change selection but it's hard also due to swipe feature). Moreover in my opinion i would extend the margin of error when choosing seat (when i use mouse i have to be precise in order to select seat). |
Aleks334
reviewed
Dec 30, 2024
|
I fixed touch and mouse events and i split seats tab into more elements to maintain readability |
Aleks334
reviewed
Jan 13, 2025
|
|
||
| return ( | ||
| <div className="relative flex h-full w-full items-center justify-center"> | ||
| {Children.map(props.children, (child, i) => { |
There was a problem hiding this comment.
I suggest using another way that doesn't require the use of Children api. It's quite rare and even in the docs they don't recommend it: https://react.dev/reference/react/Children
Aleks334
reviewed
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.