Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[email protected] doesn't support Node v4 #747

Closed
teppeis opened this issue Mar 26, 2018 · 3 comments
Closed

[email protected] doesn't support Node v4 #747

teppeis opened this issue Mar 26, 2018 · 3 comments

Comments

@teppeis
Copy link

teppeis commented Mar 26, 2018

In Node.js v4, yarn cannot install ajv:

$ yarn add ajv
yarn add v1.5.1
[1/5] 🔍  Validating package.json...
[2/5] 🔍  Resolving packages...
[3/5] 🚚  Fetching packages...
error [email protected]: The engine "node" is incompatible with this module. Expected version ">=6".                                               
error An unexpected error occurred: "Found incompatible module".
info If you think this is a bug, please open a bug report with the information provided in "/Users/teppeis/src/github.com/teppeis/kintone-plugin-manifest-validator/yarn-error.log".
info Visit https://yarnpkg.com/en/docs/cli/add for documentation about this command.

also npm warns:

$ npm install ajv
npm WARN engine [email protected]: wanted: {"node":">=6"} (current: {"node":"4.8.7","npm":"2.15.11"})
[email protected] node_modules/ajv
+-- [email protected]
+-- [email protected]
+-- [email protected]
`-- [email protected] ([email protected])

#544 introduces uri-js and it requires punycode that doesn't support Node v4.

IMO ajv can drop support Node v4 (the EOL is next month, April 2018).
It would be better to add engines field to package.json of ajv.

@epoberezkin
Copy link
Member

It looks like yarn problem, npm installs it ok: https://travis-ci.org/epoberezkin/ajv/jobs/358014029

@teppeis
Copy link
Author

teppeis commented Mar 26, 2018

@epoberezkin yes, exit with an error is yarn's expected behavior (and it has --ignore-engines option for the workaround).
But also npm shows warning.
https://travis-ci.org/epoberezkin/ajv/jobs/358014029#L462

Anyway, punycode (and uri-js) dropped support for Node v4.
mathiasbynens/punycode.js#48

But according to README, ajv supports Node.js 0.10+.

supports browsers and Node.js 0.10-8.x

@epoberezkin
Copy link
Member

README indeed need updating

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants