Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that webinstall.dev/zoxide installs more than zoxide #318

Closed
loganlinn opened this issue Dec 22, 2021 · 5 comments · Fixed by #425
Closed

Document that webinstall.dev/zoxide installs more than zoxide #318

loganlinn opened this issue Dec 22, 2021 · 5 comments · Fixed by #425

Comments

@loganlinn
Copy link

loganlinn commented Dec 22, 2021

Reviewing the script returned from curl -sS https://webinstall.dev/zoxide (gist), I was surprised to see that it installs additional tools (webi, pathman, envman, more?) to the environment that don't get cleaned up and make unannounced changes to ~/.bashrc, ~/.zshrc, etc.

I understand these sorts of installers are not for everyone and the benefits the webinstall project provides to OSS maintainers, but I have a strong feeling this sort of low-visibility "tool bundling" is unexpected behavior to most.

@ajeetdsouza
Copy link
Owner

I agree with you, I'm not a fan of how the installs happen either. I've been waiting since the maintainer of webi says he's open to fixing this, but if that doesn't happen we may have to roll our own installer instead.

dharmaturtle added a commit to dharmaturtle/zoxide that referenced this issue Jan 7, 2022
Resolves ajeetdsouza#318

I was not pleased when I blindly ran `webinstall`. Had I used more braincells I would've elected to use a package manager.
@nonissue
Copy link

Wow, this is a huge issue imo. MULTIPLE files are installed without any kind of notification:

~/.local/bin/webi
~/.local/bin/pathman
~/.local/opt/pathman-*

Additionally, a bunch of files are SILENTLY modified:

~/.bashrc
~/.profile
~/.config/fish/config.fish
~/.config/envman/PATH.env

I would never have used the webinstall.dev had I known this in advance, and yes, I should have checked more thoroughly, but I'm shocked that both the zoxide README and the actual webi shell instructions make no mention of the numerous changes made.

@ajeetdsouza
Copy link
Owner

Hey, zoxide now ships its own installer once again. Sorry this took so long!

@nonissue
Copy link

Thank you ☺️

grimm26 added a commit to grimm26/dotfiles that referenced this issue Aug 8, 2022
@coolaj86
Copy link

coolaj86 commented Nov 2, 2023

Thanks to updates in PowerShell and my better understanding of bash, Webi no longer depends on pathman.
(it never did install envman, as it never existed - that's just the folder for machine-readable ENVs)

The webi command still installs itself because of the bootstrap process (curl doesn't include a standard User-Agent string with os and arch info).

There's also now a Files section in each installer that accounts for any non-standard changes.

Webi is for an audience of people who are typically less familiar with the nuances of PATH updates, but I'm open to ideas on how to better communicate that still. I'll have to double check that there's output when ~/.bashrc and friends are modified the first time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants