Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow LLM router fails with empty preprompt #9

Open
canyon289 opened this issue Sep 27, 2023 · 4 comments
Open

Allow LLM router fails with empty preprompt #9

canyon289 opened this issue Sep 27, 2023 · 4 comments

Comments

@canyon289
Copy link
Contributor

canyon289 commented Sep 27, 2023

Would be great if it could handle cases of empty preprompt

image

@canyon289
Copy link
Contributor Author

Preprompt doesnt seem to be needed for some reason

image

@comath
Copy link
Contributor

comath commented Oct 11, 2023

The serde derive uses the default of "none" if it's not there in the JSON. This error is due to OpenAI's model's code.

We can make the default the empty string in the trait interface and trait so that we don't have to detect if it's not-none and not-empty. It would make making new models simpler.

@comath
Copy link
Contributor

comath commented Oct 11, 2023

This is also because you're using preprompt instead of system.

@canyon289
Copy link
Contributor Author

This is also because you're using preprompt instead of system.

Preprompt is what's used in llm_verification? Should this be changed there?
https://github.com/aivillage/llm_verification/blob/ad0425922616ab7779720f38daf69af5cfcbf8c8/remote_llm.py#L40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants