Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix verdi devel check-undesired-imports when tui extra is installed #6693

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

danielhollas
Copy link
Collaborator

@danielhollas danielhollas commented Jan 9, 2025

Fixes #6691.

To test the fix run

uv sync --extra tui
uv run verdi devel check-undesired-imports

This will fail on main with

Warning: Detected loaded module "asyncio"
Critical: Detected 1 unwanted modules

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 77.99%. Comparing base (b432611) to head (eb1e91b).

Files with missing lines Patch % Lines
src/aiida/cmdline/commands/cmd_devel.py 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6693      +/-   ##
==========================================
- Coverage   77.99%   77.99%   -0.00%     
==========================================
  Files         563      563              
  Lines       41762    41765       +3     
==========================================
  Hits        32570    32570              
- Misses       9192     9195       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielhollas danielhollas requested a review from unkcpz January 15, 2025 17:12
@danielhollas danielhollas force-pushed the check-undesired-imports-tui-fix branch from 1b1a850 to eb1e91b Compare January 15, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

verdi devel check-undesired-imports fails when tui extras is installed
1 participant