feat: minor improvements #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domire8
force-pushed
the
feat/traj-improv
branch
from
8e1ae8a to
d9ef328
Compare
domire8
commented
Feb 5, 2025
source/state_representation/include/state_representation/trajectory/CartesianTrajectory.hpp
Show resolved
Hide resolved
source/state_representation/include/state_representation/trajectory/TrajectoryBase.hpp
Show resolved
Hide resolved
source/state_representation/include/state_representation/trajectory/TrajectoryBase.hpp
Show resolved
Hide resolved
source/state_representation/include/state_representation/trajectory/TrajectoryBase.hpp
Show resolved
Hide resolved
source/state_representation/include/state_representation/trajectory/TrajectoryBase.hpp
Outdated
Show resolved
Hide resolved
bpapaspyros
reviewed
Feb 5, 2025
source/state_representation/include/state_representation/trajectory/TrajectoryBase.hpp
Outdated
Show resolved
Hide resolved
source/state_representation/include/state_representation/trajectory/TrajectoryBase.hpp
Outdated
Show resolved
Hide resolved
source/state_representation/include/state_representation/trajectory/TrajectoryBase.hpp
Outdated
Show resolved
Hide resolved
bpapaspyros
reviewed
Feb 5, 2025
source/state_representation/include/state_representation/trajectory/TrajectoryBase.hpp
Outdated
Show resolved
Hide resolved
This comment was marked as resolved.
This comment was marked as resolved.
bpapaspyros
approved these changes
Feb 5, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I just have a few minor things that I still had on my mind from #216. Open for discussion
Review guidelines
Estimated Time of Review: 10 minutes
Checklist before merging: