Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for 3.0.0a #24

Open
naquad opened this issue Sep 24, 2024 · 4 comments
Open

Update for 3.0.0a #24

naquad opened this issue Sep 24, 2024 · 4 comments

Comments

@naquad
Copy link

naquad commented Sep 24, 2024

A version for Sioyek Alpha release is highly desired.

The current version is not working with the alpha's DB:

  File "/home/naquad/.local/lib/python3.12/site-packages/sioyek/sioyek.py", line 877, in embed_new_annotations
    self.embed_new_highlights(colormap=colormap)
  File "/home/naquad/.local/lib/python3.12/site-packages/sioyek/sioyek.py", line 871, in embed_new_highlights
    new_highlights = self.get_non_embedded_highlights()
                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/naquad/.local/lib/python3.12/site-packages/sioyek/sioyek.py", line 992, in get_non_embedded_highlights
    candidate_highlights = self.get_highlights()
                           ^^^^^^^^^^^^^^^^^^^^^
  File "/home/naquad/.local/lib/python3.12/site-packages/sioyek/sioyek.py", line 1166, in get_highlights
    highlights = [Highlight(self, text, highlight_type, (begin_x, begin_y), (end_x, end_y)) for _, _, text, highlight_type, begin_x, begin_y, end_x, end_y in cursor.fetchall()]
                                                                                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ValueError: too many values to unpack (expected 8)
@shivams
Copy link

shivams commented Nov 13, 2024

I am also experiencing the same issue, when trying to embed annotations in file.

@ahrm
Copy link
Owner

ahrm commented Nov 14, 2024

There is now a built-in embed_annotations command in sioyek, there is no need for that extension.

@shivams
Copy link

shivams commented Nov 14, 2024

Okay. embed_annotations asks for a new file location. It doesn't embed it automatically within the current file. I was trying to define a new command _embed_annotations as following:

new_command _embed_annotations python -m sioyek.embed_annotations "%{sioyek_path}" "%{local_database}" "%{shared_database}" "%{file_path}"

But this threw the error mentioned by the OP in the issue. Is there a way to use the built-in embed_annotations to embed it in the current file automatically without asking for a new file location?

@ahrm
Copy link
Owner

ahrm commented Nov 15, 2024

No it is not possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants