Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation pillar review #2680

Merged
merged 17 commits into from
Mar 21, 2024
Merged

Documentation pillar review #2680

merged 17 commits into from
Mar 21, 2024

Conversation

jacobdadams
Copy link
Member

Review and update of the documentation pillar, including a bunch of changes to the TURN docs in collaboration with Sean. @seanfernandez and @DenisePeterson, will you please look over the TURN docs in the preview to review what we've done?

Copy link

netlify bot commented Mar 21, 2024

Deploy Preview for gis-utah ready!

Name Link
🔨 Latest commit 0913daf
🔍 Latest deploy log https://app.netlify.com/sites/gis-utah/deploys/65fca4fc13150c0008d65fa7
😎 Deploy Preview https://deploy-preview-2680--gis-utah.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 98 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

steveoh added 4 commits March 21, 2024 12:10
In earlier versions of the HTML specification, the <i> element was merely a presentational element used to display text in italics, much like the <b> element was used to display text in bold letters. This is no longer true, as these tags now define semantics rather than typographic appearance. A browser will typically still display the contents of the <i> element in italic type, but is, by definition, no longer required to do so. To display text in italic type, authors should use the CSS font-style property.
Copy link
Member

@steveoh steveoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great. a couple of review comments and a question, and suggestion. let me know!

src/pages/documentation/policy/license.astro Outdated Show resolved Hide resolved
src/pages/documentation/policy/license.astro Outdated Show resolved Hide resolved
src/pages/documentation/turn/connecting.astro Show resolved Hide resolved
src/pages/documentation/turn/connecting.astro Show resolved Hide resolved
@steveoh steveoh enabled auto-merge (squash) March 21, 2024 18:36
steveoh and others added 2 commits March 21, 2024 14:31
TURN GPS network
Nevada GPS nework
Co-authored-by: Nathan Kota <[email protected]>
@steveoh steveoh merged commit 86ca86a into main Mar 21, 2024
6 checks passed
@steveoh steveoh deleted the mj-doc branch March 21, 2024 21:24
@seanfernandez
Copy link
Contributor

I have read through the deploy preview of Products - TURN GPS and don't see any needed changes. Please publish. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants