Skip to content
This repository has been archived by the owner on Jul 4, 2021. It is now read-only.

Implement the Vary header in the response #14

Open
darkweak opened this issue Jul 3, 2021 · 1 comment
Open

Implement the Vary header in the response #14

darkweak opened this issue Jul 3, 2021 · 1 comment

Comments

@darkweak
Copy link

darkweak commented Jul 3, 2021

Hi mate, thanks for your good work to implement Imaginary as Træfik plugin.
Someone asked me to support your implementation in my cache system (darkweak/souin#91). Instead of reinventing the wheel we could achieve to a working solution if you're able to implement the Vary header. I don't know which headers Imaginary uses to transform images, generate the most comfortable and most optimise image depending the client request.

You'll just have to include the vary header on L.137 inside the image_optimizer.go file.

rw.Header().Set("vary", []string{"header1", "header2", ...})

Open to discuss about that implementation with you.

@agravelot
Copy link
Owner

Hi, I do not plan to maintain this repository since it was used for a job offer at Traefik Labs.
Feel free to fork and maintain it on your own, i'll archive this repository.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants