Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish new version of Torii #7

Open
2 of 6 tasks
halfbyte opened this issue Aug 12, 2022 · 8 comments
Open
2 of 6 tasks

Publish new version of Torii #7

halfbyte opened this issue Aug 12, 2022 · 8 comments

Comments

@halfbyte
Copy link
Collaborator

halfbyte commented Aug 12, 2022

Now that I finally have access to the npm project, let's make this a checklist to release 1.0.0

  • Make sure README is updated to not contain misleading info (Some more fixes in README #9)
  • Make sure package.json does not contain any links to the old project or gh pages
  • Update the gh pages branch and publish it
  • Make sure we don't have any more autoinjections left over
  • Betatesting
  • Publish 1.0.0
@Gaurav0
Copy link

Gaurav0 commented Sep 1, 2022

Hey, spoke to Matt this morning. Apparently the issue is difficult because Vestorly paid to create/maintain the package. He encourages forking with a different name.

@mpminardi
Copy link

Have created a PR here that brings back the torii -> @adopted-ember-addons/torii rename in light of the above.

@halfbyte
Copy link
Collaborator Author

halfbyte commented Sep 9, 2022

@mpminardi Thanks 💟 , I'll come back to that. In the meantime @joebartels has reached out to me and connected me with someone from Vestorly in the hopes that I get some direct feedback from them. Until then I'll keep my feet still.

@halfbyte
Copy link
Collaborator Author

Good news everyone: I now have access to the npm project. Please give me a couple of days to figure out some of the finer details, updating the documents and everything. There were also 1 or 2 remaining auto injections deprecation warnings I noticed that we need to fix.

@Gaurav0 Regarding Matt's concerns: I've talked to Joseph and the bottom line is this: We've done our due dilligence to get answers from Vestorly and they chose to ignore the issue, so we can more or less assume that publishing a new version to npm from a different repo will not even be noticed by them. In fact, nobody from Vestorly currently has access to the npm project, either by mistake or my negligence.

@Gaurav0
Copy link

Gaurav0 commented Jan 30, 2023

@halfbyte I would like to see other projects adopt this but some would like to see it officially released as 1.0. What needs to be done to make that happen?

@halfbyte
Copy link
Collaborator Author

@Gaurav0 I need some help from someone with Org access to reconfigure a couple of things on this repo. I have mostly ignored this because the Beta is working for us and I didn't have the time to chase people on Discord. I see your concern and will try to chase someone down this week to make it happen.

If all else fails, I can release a 1.0.0 without those changes.

@halfbyte
Copy link
Collaborator Author

halfbyte commented Jul 4, 2023

Heya, just a quick heads up: My plan is to somehow get someone from the Org team to help me walk through the todo list and set this up in a way that it would work without my help in the future (As I realise that I wasn't that helpful in the past few months)

I'm currently working on getting the tests green for Ember 5.x, so I guess another beta release (I'll probably still call it 1.0.0 unless someone thinks that that's a bad idea) is coming soon-ish.

@xiuzhong
Copy link

@halfbyte Hey, can I get an update on this issue and your plan? Would the release of 1.0.0 remove the ESA deprecation?

deprecate('Ember Simple Auth: The Torii authenticator is deprecated.'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants