Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu is missing explicit content-box on unavailable icon #7571

Closed
dsmmcken opened this issue Jan 6, 2025 · 1 comment · Fixed by #7572
Closed

Menu is missing explicit content-box on unavailable icon #7571

dsmmcken opened this issue Jan 6, 2025 · 1 comment · Fixed by #7572

Comments

@dsmmcken
Copy link
Contributor

dsmmcken commented Jan 6, 2025

Provide a general summary of the issue here

Similar to #6470 and #7456 when a Menu is marked as unavailable it gets a contextual help InfoOutline icon, if border-box is set in the a global reset, the icon doesn't show.

https://react-spectrum.adobe.com/react-spectrum/Menu.html#unavailable-items

🤔 Expected Behavior?

Icon should be visible

😯 Current Behavior

Icon is not shown.

💁 Possible Solution

This icon doesn't have an explicit box-sizing: content-box; which was added for chevron and checkmark, but missed on the InfoOutline icon. Add a class for the InfoOutline and add it to the icon.

🔦 Context

No response

🖥️ Steps to Reproduce

See reproduction steps in #6470 but use isUnavailable.

Version

3.21.0

What browsers are you seeing the problem on?

Chrome

If other, please specify.

No response

What operating system are you using?

Linux

🧢 Your Company/Team

No response

🕷 Tracking Issue

No response

@yihuiliao
Copy link
Member

Seems reasonable to me given that we've done this in other components. Opened a PR #7572

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants