Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for node22 #678

Closed
RemoLiechti opened this issue Oct 22, 2024 · 2 comments
Closed

Support for node22 #678

RemoLiechti opened this issue Oct 22, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@RemoLiechti
Copy link

RemoLiechti commented Oct 22, 2024

Expected Behaviour

According to the package.json, node versions >=18 are supported.
When I execute an aio command using node22, I do not want to get a punycode warning.

Actual Behaviour

However, when executing aio plugins I get a warning

$ aio plugins
(node:32423) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
(Use `node --trace-deprecation ...` to show where the warning was created)

Known details:
the punycode comes in through eslint(even latest 9.13.0) and @adobe/eslint-config-aio-lib-config that both use ajv
│ ├─┬ [email protected]
│ │ ├── [email protected] deduped
│ │ ├── [email protected]
│ │ ├── [email protected]
│ │ └─┬ [email protected]
│ │ └── [email protected]

I tried to workaround it by using https://github.com/andreinwald/uri-js-replace but failes to do so.

@moritzraho moritzraho added the bug Something isn't working label Oct 22, 2024
@aiojbot
Copy link

aiojbot commented Oct 22, 2024

JIRA issue created: https://jira.corp.adobe.com/browse/ACNA-3246

@moritzraho
Copy link
Member

duplicate of #620

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants